Conversation
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Deploying waveterm with
|
| Latest commit: |
3fec303
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://52d27fae.waveterm.pages.dev |
| Branch Preview URL: | https://copilot-create-preview-conte.waveterm.pages.dev |
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add preview context menu component for mock environment
Add working preview-server context menus with nested submenu support
Mar 11, 2026
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot
AI
changed the title
Add working preview-server context menus with nested submenu support
Add preview-native context menus and fix submenu rendering in Mar 11, 2026
frontend/preview
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
|
|
||
| function activateItem(item: ContextMenuItem, closeMenu: () => void): void { | ||
| closeMenu(); | ||
| item.click?.(); |
Contributor
There was a problem hiding this comment.
WARNING: Potential uncaught exception - if item.click?.() throws, the menu is already closed (line 78) and the error propagates up without being caught. Consider wrapping in try-catch to handle errors gracefully and ensure the menu state remains consistent.
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (4 files)
Other Observations: The new context menu implementation (
The test file correctly mocks the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frontend/previewwas still routing context menus through the Electron-backed production path, so preview menus did not behave correctly. This change adds a preview-native menu renderer, then tightens its sizing and fixes submenu clipping so nested menus are fully visible and usable.Preview-native context menu host
frontend/preview/preview-contextmenu.tsx@floating-ui/reactContextMenuItemfeatures already used by previews:Mock env integration
WaveEnv.showContextMenupath to the preview rendererenv.showContextMenu(menu, e))Preview root mounting
frontend/preview/preview.tsxMenu sizing + submenu visibility
overflow-visibleso submenu panels are not clipped by the parent container✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.