chore(deps)!: upgrade serialize-javascript to v7 and node to v20#650
chore(deps)!: upgrade serialize-javascript to v7 and node to v20#650dargmuesli wants to merge 1 commit intowebpack:mainfrom
Conversation
BREAKING CHANGES: drop support for EOL node versions
|
|
evenstensberg
left a comment
There was a problem hiding this comment.
We need to discuss this because we try to support the most oldest node versions based on that people use legacy deps. Thanks for the PR!
Is this pacakge dead now because you cant do security upgrades because of legacy node? |
|
I think one of the better paths forward would be for webpack to fork the package, though I'd be happy to do that if they'd prefer not to have it under their org |
Would it therefore make sense to create a new major version, 6, that drops support for older node versions and then, if support for older versions is necessary, backport any changes to version 5 as necessary? |
|
You can bump the major version if you are careful of breaking changes. |
|
We can't it is a breaking change for webpack |
|
There's a PR to backport the fix to |
|
I heard that npm does not respect the engines field when it selects a version of a package. We will not be able to avoid breaking changes. |
Summary
Upgrade
serialize-javascriptto v7 to resolve GHSA-5c6j-r48x-rmvqWhat kind of change does this PR introduce?
Chore.
Resolves #644
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
drop support for EOL node versions
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Minimum support node js version maybe.
Use of AI
nope