Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 3 3
Lines 332 332
Branches 122 122
=======================================
Hits 321 321
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for fixing this. Since you are now going to keep a local copy of |
|
@raheel-iso365 we have a lint step and dependabot setup, so when |
|
@alexander-akait |
This is to resolve a security vulnerability in serialize-javascript 6.0.2 [1], which we had as a transitive dependency through webpack > terser-webpack-plugin. As it happens the fix for in terser-webpack-plugin 5.3.17 was to remove the dependency on serialize-javascript completely [2]. [1] yahoo/serialize-javascript#207 [2] webpack/terser-webpack-plugin#654
| var nodeCrypto = require('crypto'); | ||
|
|
||
| crypto.getRandomValues = function(typedArray) { | ||
| // Генерируем буфер случайных байтов нужной длины |
There was a problem hiding this comment.
this and following comments are not present in the scripts/copy-serialize-javascript.js, which is supposed to generate (prepend fallback to) this file.
this necessarily means lint:serialize-javascript will always fail, since it compares “fallback with comments + copied code” to “fallback without comments + copied code”, those are never equal.
comments are in russian for some reason, interesting!
Summary
Update
serialize-javascript, because we can't use the latest version ofserialize-javascript(due to support Node.js@10), we are using alternative approach - script to copy content of this package (and lint), in future we are planning to create the similar API on webpack side to avoid such situation (we already have the almost same API under the hood for caches into webpack core), so this solution is just a fast fix.fixes #644
fixes #650
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Existing
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing
Use of AI
No