-
Notifications
You must be signed in to change notification settings - Fork 14
fix: update pyproject.toml and requirements.txt with required fields #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update pyproject.toml and requirements.txt with required fields #49
Conversation
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwbrooks Amazing improvements to project health! Let's continue to prefer the latest standards in samples 💌 🐍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪓 question: Should we prefer pyproject.toml overall? IIRC requirements.txt isn't recommended going forward but no blocker here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I think so. In future iterations, let's start only including pyproject.toml.
| [tool.setuptools.packages.find] | ||
| include = ["agent*", "listeners*"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️🗨️ praise: This might be difficult to maintain onward but perhaps we revisit sample structure later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I wonder if we should start to store everything in src/?
| dependencies = [ | ||
| "slack-sdk==3.40.0", | ||
| "slack-bolt==1.27.0", | ||
| "slack-cli-hooks<1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔭 question: I'm alright keeping this as a required dependency, but would we want to move this to optional? I'm also still a believer in pinned version FWIW-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let's move it to optional in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional and pinned >> 👀
|
Thanks for the review and great ideas! Let's incorporate these in the future iterations of the Sample Apps! |
Type of change
Summary
This pull request updated
pyproject.tomlandrequirements.txtwith the following:pip install -e .error by adding the required[tool.setuptools.packages.find]fields topyproject.tomlpyproject.tomlwith the name, version, and minimum Python version fieldspyproject.tomlwith the dependencies for developers who prefer to usepyproject.tomlinstead ofrequirementst.txtslack-cli-hooks<1.0.0to bothrequirements.txtandpyproject.tomlbecause we're starting to include this dependency in sample appsTest Steps
Requirements