Skip to content

Conversation

@mwbrooks
Copy link
Member

Type of change

  • New feature
  • Bug fix
  • Documentation

Summary

This pull request updated pyproject.toml and requirements.txt with the following:

  • Fixes pip install -e . error by adding the required [tool.setuptools.packages.find] fields to pyproject.toml
  • Updates pyproject.toml with the name, version, and minimum Python version fields
  • Updates pyproject.toml with the dependencies for developers who prefer to use pyproject.toml instead of requirementst.txt
  • Add slack-cli-hooks<1.0.0 to both requirements.txt and pyproject.toml because we're starting to include this dependency in sample apps

Test Steps

# Setup Virtual Environment
$ python3 -m venv .venv
$ source .venv/bin/activate

$ pip install -e .
# → Confirm no errors

$ pip install -r requirements.txt
# → Confirm no errors

Requirements

  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@mwbrooks mwbrooks requested review from srtaalej and zimeg February 11, 2026 00:31
@mwbrooks mwbrooks self-assigned this Feb 11, 2026
@mwbrooks mwbrooks added the bug Something isn't working label Feb 11, 2026
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks Amazing improvements to project health! Let's continue to prefer the latest standards in samples 💌 🐍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 question: Should we prefer pyproject.toml overall? IIRC requirements.txt isn't recommended going forward but no blocker here!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I think so. In future iterations, let's start only including pyproject.toml.

Comment on lines +19 to +20
[tool.setuptools.packages.find]
include = ["agent*", "listeners*"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️‍🗨️ praise: This might be difficult to maintain onward but perhaps we revisit sample structure later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I wonder if we should start to store everything in src/?

dependencies = [
"slack-sdk==3.40.0",
"slack-bolt==1.27.0",
"slack-cli-hooks<1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔭 question: I'm alright keeping this as a required dependency, but would we want to move this to optional? I'm also still a believer in pinned version FWIW-

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's move it to optional in the future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional and pinned >> 👀

@mwbrooks
Copy link
Member Author

Thanks for the review and great ideas! Let's incorporate these in the future iterations of the Sample Apps!

@mwbrooks mwbrooks merged commit 298b435 into feat-ai-apps-thinking-steps Feb 11, 2026
2 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-update-pyproject-toml branch February 11, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants