Skip to content

exir: enable exir test targets in OSS buck2 CI build #17589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mergennachin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

exir: enable exir test targets in OSS buck2 CI build #17589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .ci/scripts/unittest-buck2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,14 @@ done

# Build only without testing
buck2 build //codegen/tools/... \
//exir/_serialize/test/... \
//exir/backend/test:test_delegate_map_builder \
//exir/backend/test:test_graph_partition \
//exir/backend/test:test_group_partitioner \
//exir/backend/test:test_passes \
//exir/dialects/backend/test/... \
//exir/dialects/edge/op/... \
//exir/operator/... \
//extension/llm/runner/io_manager:io_manager \
//extension/llm/modules/... \
//extension/llm/runner:multimodal_runner_lib \
Expand Down
11 changes: 6 additions & 5 deletions exir/_serialize/test/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

oncall("executorch")

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_program",
srcs = [
"test_program.py",
Expand All @@ -15,7 +16,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_flatbuffer",
srcs = [
"test_flatbuffer.py",
Expand All @@ -25,7 +26,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_cord",
srcs = [
"test_cord.py",
Expand All @@ -35,7 +36,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_named_data_store",
srcs = [
"test_named_data_store.py",
Expand All @@ -45,7 +46,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_serialize",
srcs = [
"test_serialize.py",
Expand Down
28 changes: 14 additions & 14 deletions exir/backend/test/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ fbcode_target(_kind = runtime.python_library,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_backend_with_named_data_map",
srcs = [
"test_backend_with_named_data_map.py",
Expand Down Expand Up @@ -158,7 +158,7 @@ fbcode_target(_kind = runtime.python_library,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_backends",
srcs = [
"test_backends.py",
Expand Down Expand Up @@ -190,7 +190,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_to_backend_multi_method",
srcs = [
"test_to_backend_multi_method.py",
Expand Down Expand Up @@ -243,7 +243,7 @@ fbcode_target(_kind = runtime.python_library,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_debug_handle_map",
srcs = [
"test_debug_handle_map.py",
Expand All @@ -260,7 +260,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_backends_lifted",
srcs = [
"test_backends_lifted.py",
Expand Down Expand Up @@ -292,7 +292,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_lowered_backend_module",
srcs = [
"test_lowered_backend_module.py",
Expand All @@ -317,7 +317,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_graph_partition",
srcs = [
"test_graph_partition.py",
Expand All @@ -334,7 +334,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_backends_nested",
srcs = [
"test_backends_nested.py",
Expand All @@ -360,7 +360,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_delegate_map_builder",
srcs = [
"test_delegate_map_builder.py",
Expand All @@ -374,7 +374,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_utils",
srcs = [
"test_utils.py",
Expand All @@ -392,7 +392,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_partitioner",
srcs = [
"test_partitioner.py",
Expand All @@ -418,7 +418,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_passes",
srcs = [
"test_passes.py",
Expand All @@ -430,7 +430,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_compatibility",
srcs = [
"test_compatibility.py",
Expand All @@ -449,7 +449,7 @@ fbcode_target(_kind = python_unittest,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_group_partitioner",
srcs = [
"test_group_partitioner.py",
Expand Down
3 changes: 2 additions & 1 deletion exir/dialects/backend/test/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

oncall("executorch")

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_backend_ops",
srcs = [
"test_backend_ops.py",
Expand Down
2 changes: 1 addition & 1 deletion exir/dialects/edge/op/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ fbcode_target(_kind = runtime.python_library,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_api",
srcs = [
"test/test_api.py",
Expand Down
7 changes: 4 additions & 3 deletions exir/emit/test/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

oncall("executorch")
# add this empty BUCK file to unblock landing. Without this, we get land error:
# "No build file at xplat/executorch/exir/tests/BUCK when resolving target fbsource//xplat/executorch/exir/tests:."


# !!!! fbcode/executorch/exir/emit/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!!

load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")


fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
# @autodeps-skip pybindings don't work well with autodeps
name = "emit",
srcs = [
Expand Down
2 changes: 1 addition & 1 deletion exir/operator/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ fbcode_target(_kind = runtime.python_library,
],
)

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
name = "test_operator",
srcs = [
"test/test_operator.py",
Expand Down
3 changes: 2 additions & 1 deletion exir/program/test/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

oncall("executorch")

fbcode_target(_kind = python_unittest,
fbcode_target(_kind = runtime.python_test,
# @autodeps-skip pybindings don't work well with autodeps
name = "test_program",
srcs = [
Expand Down
6 changes: 3 additions & 3 deletions exir/tests/TARGETS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ runtime.python_library(
],
)

python_unittest(
runtime.python_test(
name = "tracer",
srcs = [
"test_tracer.py",
Expand Down Expand Up @@ -176,7 +176,7 @@ python_unittest(
],
)

python_unittest(
runtime.python_test(
name = "memory_planning",
srcs = [
"test_memory_planning.py",
Expand Down Expand Up @@ -335,7 +335,7 @@ python_unittest(
],
)

python_unittest(
runtime.python_test(
name = "capture",
srcs = [
"test_capture.py",
Expand Down
1 change: 1 addition & 0 deletions shim_et/xplat/executorch/build/env_interface.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ def _remove_unsupported_kwargs(kwargs):
kwargs.pop("types", None) # will have to find a different way to handle .pyi files in oss
kwargs.pop("resources", None) # doesn't support resources in python_library/python_binary yet
kwargs.pop("feature", None) # internal-only, used for Product-Feature Hierarchy (PFH)
kwargs.pop("supports_static_listing", None) # fbcode-only python_test kwarg
return kwargs

def _patch_headers(kwargs):
Expand Down
Loading