exir: enable exir test targets in OSS buck2 CI build#17589
exir: enable exir test targets in OSS buck2 CI build#17589mergennachin wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17589
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit bc0347f with merge base 1dffefd ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR updates the build configuration for the test_flatbuffer test to enable it in the buck2 CI build pipeline. The test is switched from python_unittest to runtime.python_test to support OSS (Open Source Software) dependency path rewriting, and is added to the buck2 CI script's build-only section.
Changes:
- Modified test_flatbuffer target to use runtime.python_test instead of python_unittest for OSS dependency path rewriting
- Added test_flatbuffer to the buck2 CI build-only targets list
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| exir/_serialize/test/BUCK | Updated test_flatbuffer from python_unittest to runtime.python_test and imported runtime module |
| .ci/scripts/unittest-buck2.sh | Added test_flatbuffer to the build-only section of buck2 CI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5bd992f to
dc3285b
Compare
Switch python_unittest to runtime.python_test across exir/ test BUCK files so deps get //executorch/ path rewriting and //caffe2 stripping for OSS buck2. Add supports_static_listing to the unsupported kwargs list in env_interface.bzl so runtime.python_test can handle that fbcode-only kwarg. This enables buck2 build (not test) of 12 exir test targets in CI, up from 3 previously.
dc3285b to
bc0347f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
exir/program/test/BUCK:2
- The python_unittest import is unused since all tests in this file have been converted to runtime.python_test. Consider removing this import to keep the file clean.
load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
exir/emit/test/BUCK:2
- The python_unittest import is unused since the only test in this file has been converted to runtime.python_test. Consider removing this import to keep the file clean.
load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D93873553. |
Switch python_unittest to runtime.python_test across exir/ test BUCK
files so deps get //executorch/ path rewriting and //caffe2 stripping
for OSS buck2. Add supports_static_listing to the unsupported kwargs
list in env_interface.bzl so runtime.python_test can handle that
fbcode-only kwarg.
This enables buck2 build (not test) of 12 exir test targets in CI,
up from 3 previously.