Skip to content

Comments

exir: enable exir test targets in OSS buck2 CI build#17589

Open
mergennachin wants to merge 1 commit intomainfrom
exir-flatbuffer-buck2-ci
Open

exir: enable exir test targets in OSS buck2 CI build#17589
mergennachin wants to merge 1 commit intomainfrom
exir-flatbuffer-buck2-ci

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Feb 20, 2026

Switch python_unittest to runtime.python_test across exir/ test BUCK
files so deps get //executorch/ path rewriting and //caffe2 stripping
for OSS buck2. Add supports_static_listing to the unsupported kwargs
list in env_interface.bzl so runtime.python_test can handle that
fbcode-only kwarg.

This enables buck2 build (not test) of 12 exir test targets in CI,
up from 3 previously.

Copilot AI review requested due to automatic review settings February 20, 2026 15:38
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 20, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17589

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit bc0347f with merge base 1dffefd (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2026
@mergennachin mergennachin requested a review from lucylq February 20, 2026 15:38
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the build configuration for the test_flatbuffer test to enable it in the buck2 CI build pipeline. The test is switched from python_unittest to runtime.python_test to support OSS (Open Source Software) dependency path rewriting, and is added to the buck2 CI script's build-only section.

Changes:

  • Modified test_flatbuffer target to use runtime.python_test instead of python_unittest for OSS dependency path rewriting
  • Added test_flatbuffer to the buck2 CI build-only targets list

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
exir/_serialize/test/BUCK Updated test_flatbuffer from python_unittest to runtime.python_test and imported runtime module
.ci/scripts/unittest-buck2.sh Added test_flatbuffer to the build-only section of buck2 CI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergennachin mergennachin force-pushed the exir-flatbuffer-buck2-ci branch from 5bd992f to dc3285b Compare February 20, 2026 15:44
Switch python_unittest to runtime.python_test across exir/ test BUCK
files so deps get //executorch/ path rewriting and //caffe2 stripping
for OSS buck2. Add supports_static_listing to the unsupported kwargs
list in env_interface.bzl so runtime.python_test can handle that
fbcode-only kwarg.

This enables buck2 build (not test) of 12 exir test targets in CI,
up from 3 previously.
@mergennachin mergennachin force-pushed the exir-flatbuffer-buck2-ci branch from dc3285b to bc0347f Compare February 20, 2026 16:06
Copilot AI review requested due to automatic review settings February 20, 2026 16:06
@mergennachin mergennachin changed the title exir: add flatbuffer serialize test to buck2 CI build exir: enable exir test targets in OSS buck2 CI build Feb 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

exir/program/test/BUCK:2

  • The python_unittest import is unused since all tests in this file have been converted to runtime.python_test. Consider removing this import to keep the file clean.
load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")

exir/emit/test/BUCK:2

  • The python_unittest import is unused since the only test in this file has been converted to runtime.python_test. Consider removing this import to keep the file clean.
load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@meta-codesync
Copy link
Contributor

meta-codesync bot commented Feb 20, 2026

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D93873553.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant