Fix remaining clippy issues with --all-targets#1113
Merged
Conversation
DavisVaughan
approved these changes
Mar 13, 2026
|
|
||
| ($expression:expr, $pattern:pat_param) => { | ||
| assert!(matches!($expression, $pattern)) | ||
| #[allow(clippy::redundant_pattern_matching)] |
Contributor
There was a problem hiding this comment.
do you know what this one is about?
Contributor
Author
There was a problem hiding this comment.
That prevents clippy from complaining that we could use .is_some() instead of Some(_)
lionel-
force-pushed
the
task/clippy-auto-all-targets
branch
from
ff811c7 to
6715348
Compare
lionel-
force-pushed
the
task/clippy-manual-all-targets
branch
from
8aa7393 to
d4d8027
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #1112
Progress towards #1104