Enable clippy linting in repo#1114
Open
lionel- wants to merge 6 commits intotask/clippy-manual-all-targetsfrom
Open
Enable clippy linting in repo#1114lionel- wants to merge 6 commits intotask/clippy-manual-all-targetsfrom
lionel- wants to merge 6 commits intotask/clippy-manual-all-targetsfrom
Conversation
Contributor
Author
|
oh clippy has LSP fixes! 
|
DavisVaughan
approved these changes
Mar 13, 2026
Comment on lines
+16
to
17
| #[cfg(target_os = "macos")] | ||
| use ark_test::SourceFile; |
| #[cfg(target_os = "macos")] | ||
| use ark_test::SourceFile; | ||
| use url::Url; | ||
|
|
Contributor
There was a problem hiding this comment.
Locally the clippy command does not pass for me
cargo clippy --all-targets --all-features --locked -- -D warnings
error: this expression always evaluates to false
--> crates/harp/src/command.rs:32:14
|
32 | assert!(!COMMAND_R_NAMES.is_empty());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_is_empty
= note: `-D clippy::const-is-empty` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::const_is_empty)]`
error: this expression always evaluates to false
--> crates/harp/src/command.rs:101:14
|
101 | assert!(!COMMAND_R_NAMES.is_empty());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_is_empty
error: could not compile `harp` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `harp` (lib test) due to 2 previous errors
And indeed LSP clippy is flagging this
Comment on lines
+30
to
+32
| - uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| save-if: ${{ github.ref == 'refs/heads/main' }} |
Contributor
There was a problem hiding this comment.
IIUC this is actually useful because to run clippy you have to compile
| cargo clippy -V | ||
|
|
||
| - name: "Check clippy" | ||
| run: cargo clippy --all-targets --all-features --locked -- -D warnings |
Contributor
There was a problem hiding this comment.
Ruff puts this in their AGENTS.md, maybe do that?
https://github.com/search?q=repo%3Aastral-sh%2Fruff+%22cargo+clippy%22&type=code
|
|
||
| - name: "Check clippy" | ||
| run: cargo clippy --all-targets --all-features --locked -- -D warnings | ||
|
|
Contributor
There was a problem hiding this comment.
I would also appreciate just clippy that calls this exact command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #1113
Closes #1104
On CI. Config taken from https://github.com/astral-sh/ruff/blob/56eb6b62936142c6ab2bdf0d7b864e32399e02a8/.github/workflows/ci.yaml#L243-L263
In IDEs via rust-analyzer's
checkconfig.I'm a bit hesitant enabling it in rust-analyser because of this (from #1104 (comment)):
One UX downside to be aware of: After each edits, clippy runs longer checks on the repo, which locks other gestures requiring compilation (running tests etc).
But I guess we can override in our personal configs if we want a different workflow (check with clippy before sending PR).