Skip to content

Fix TypeError in version display by adopting importlib.metadata #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sauravkeshrii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TypeError in version display by adopting importlib.metadata #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ OLD
.vscode
dist
build
rvc3python.egg-info/
16 changes: 9 additions & 7 deletions RVC3/bin/rvctool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import importlib.metadata
#!/usr/bin/env python3

# a simple Robotics & Vision Toolbox "shell", runs Python3 and loads
Expand All @@ -12,6 +13,7 @@
# export RVCTOOL="-n"

# import stuff
import importlib.metadata
import os
from pathlib import Path
import sys
Expand Down Expand Up @@ -183,17 +185,17 @@ def make_banner(args):

versions = []
if args.robot:
versions.append(f"RTB=={version('roboticstoolbox-python')}")
versions.append(f"RTB=={importlib.metadata.version('roboticstoolbox-python')}")
if args.vision:
versions.append(f"MVTB=={version('machinevision-toolbox-python')}")
versions.append(f"MVTB=={importlib.metadata.version('machinevision-toolbox-python')}")
try:
versions.append(f"SG=={version('spatialmath-python')}")
versions.append(f"SG=={importlib.metadata.version('spatialmath-python')}")
except:
pass
versions.append(f"SMTB=={version('spatialmath-python')}")
versions.append(f"NumPy=={version('numpy')}")
versions.append(f"SciPy=={version('scipy')}")
versions.append(f"Matplotlib=={version('matplotlib')}")
versions.append(f"SMTB=={importlib.metadata.version('spatialmath-python')}")
versions.append(f"NumPy=={importlib.metadata.version('numpy')}")
versions.append(f"SciPy=={importlib.metadata.version('scipy')}")
versions.append(f"Matplotlib=={importlib.metadata.version('matplotlib')}")

# create banner
banner += " (" + ", ".join(versions) + ")"
Expand Down