Fix TypeError in version display by adopting importlib.metadata#27
Open
sauravkeshrii wants to merge 1 commit intopetercorke:mainfrom
Open
Fix TypeError in version display by adopting importlib.metadata#27sauravkeshrii wants to merge 1 commit intopetercorke:mainfrom
sauravkeshrii wants to merge 1 commit intopetercorke:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical bug in
rvctool.pywhere the script calledversion('package-name')– but theversionfunction takes no arguments, leading to aTypeErrorat startup.The issue is resolved by replacing the erroneous calls with the standard
importlib.metadata.version('package-name')method, which reliably retrieves the installed version of any Python package. A helper functionget_versiongracefully handles missing packages by returning"not installed", preserving the original behaviour.Additionally, the auto‑generated
rvc3python.egg-info/directory has been added to.gitignoreto keep the working directory clean and prevent accidental commits.Changes
import importlib.metadataget_version(pkg_name)helperversion(...)calls withget_version(...).gitignoreto ignorervc3python.egg-info/Testing
TypeErrorThis fix makes the tool more robust and user‑friendly for everyone.