Skip to content

test: increase debugger waitFor timeout on macOS and Windows #61902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcollina wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

test: increase debugger waitFor timeout on macOS and Windows #61902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/common/debugger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@ const BREAK_MESSAGE = new RegExp('(?:' + [
].join('|') + ') in', 'i');

let TIMEOUT = common.platformTimeout(10000);
// Some macOS and Windows machines require more time to receive the outputs from the client.
// Some macOS and Windows machines require more time to receive the outputs from the
// client, especially under CI load where the async Debugger.getScriptSource CDP
// round-trip in the initial break handler can be slow.
// https://github.com/nodejs/build/issues/3014
if (common.isWindows || common.isMacOS) {
TIMEOUT = common.platformTimeout(15000);
TIMEOUT = common.platformTimeout(30000);
}

function isPreBreak(output) {
Expand Down
Loading