test: increase debugger waitFor timeout on macOS and Windows#61902
Open
mcollina wants to merge 1 commit intonodejs:mainfrom
Open
test: increase debugger waitFor timeout on macOS and Windows#61902mcollina wants to merge 1 commit intonodejs:mainfrom
mcollina wants to merge 1 commit intonodejs:mainfrom
Conversation
The test-debugger-restart-message test is flaky on macOS CI because the Debugger.getScriptSource CDP round-trip in the initial break handler can be slow under CI load, causing the 15s timeout to be exceeded. Increase the macOS/Windows timeout from 15s to 30s to provide adequate headroom.
nodejs-github-bot
added
needs-ci
legendecas
approved these changes
Feb 20, 2026
StefanStojanovic
approved these changes
Feb 20, 2026
cjihrig
approved these changes
Feb 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61902 +/- ##
==========================================
+ Coverage 89.75% 89.77% +0.01%
==========================================
Files 674 674
Lines 204416 204886 +470
Branches 39285 39377 +92
==========================================
+ Hits 183472 183929 +457
Misses 13227 13227
- Partials 7717 7730 +13 🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
Collaborator
mcollina
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
test-debugger-restart-messagetest is flaky on macOS CI. TheDebugger.on('paused')handler in the inspect REPL prints the "break in" message only after an asyncDebugger.getScriptSourceCDP round-trip to V8 completes. On loaded macOS CI machines, this round-trip can exceed the 15s timeout.The timeout has already been bumped twice (5s→10s in #56970, 10s→15s for macOS in #60367).
platformTimeout()applies no multiplier for macOS, so the raw ms value is the actual timeout. Doubling to 30s provides adequate headroom.Test plan
test-debugger-restart-messagepasses locally