Expand omni search tests to cover notes/todos, dedup, and ordering#913
Merged
multiplex55 merged 2 commits intomasterfrom Feb 28, 2026
Merged
Expand omni search tests to cover notes/todos, dedup, and ordering#913multiplex55 merged 2 commits intomasterfrom
multiplex55 merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
noteandtodosources alongside apps/bookmarks/folders in integration scenarios.Description
tests/omni_search_plugin.rsto add a reusablesetup_fixture()that usestempdir()+set_current_dir(...)and setsML_NOTES_DIRbefore seeding data.save_bookmarks,save_folders,save_notes, andsave_todosin the fixture.o_list_includes_notes_and_todos,o_list_with_query_filters_notes_todos_and_apps,o_prefix_matches_non_list_path,o_list_dedups_duplicate_rows_across_sources, ando_list_order_is_deterministic_for_same_input.label_and_desc_same_returns_actionand formatted the test file withcargo fmt.Testing
cargo fmt -- tests/omni_search_plugin.rs, which completed successfully.cargo test --test omni_search_plugin, but the build failed in this environment due to thealsa-syscrate requiring a systemalsadevelopment package (alsa.pc) viapkg-config.cargo test --no-default-features --test omni_search_plugin, which also failed for the same missing system dependency.Codex Task