Skip to content

Clean up InvokeMethodExpression.Accept() and confirm ExpressionStatement/InvokeMethodExpression visitor support #9907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −6
Draft

Clean up InvokeMethodExpression.Accept() and confirm ExpressionStatement/InvokeMethodExpression visitor support #9907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f934c3
Initial plan
Copilot Mar 4, 2026
5b5af52
Add Accept/Visit for ExpressionStatement and InvokeMethodExpression; …
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chronus/changes/copilot-add-visit-implementations-2026-03-04-17-09-00.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
changeKind: internal
packages:
- "@typespec/http-client-csharp"
---

Add `Accept`/`Visit` support for `ExpressionStatement` and `InvokeMethodExpression` to the `LibraryVisitor`. This allows visitors to intercept and modify these nodes during code generation.
6 changes: 0 additions & 6 deletions ...t-csharp/generator/Microsoft.TypeSpec.Generator/src/Expressions/InvokeMethodExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,6 @@ internal override void Write(CodeWriter writer)

invokeMethod.InstanceReference = newInstanceReference;
invokeMethod.Arguments = arguments;
invokeMethod.MethodName = invokeMethod.MethodName;
invokeMethod.MethodSignature = invokeMethod.MethodSignature;
invokeMethod.TypeArguments = invokeMethod.TypeArguments;
invokeMethod.CallAsAsync = invokeMethod.CallAsAsync;
invokeMethod.AddConfigureAwaitFalse = invokeMethod.AddConfigureAwaitFalse;
invokeMethod.ExtensionType = invokeMethod.ExtensionType;

return invokeMethod;
}
Expand Down