Clean up InvokeMethodExpression.Accept() and confirm ExpressionStatement/InvokeMethodExpression visitor support#9907
Draft
Clean up InvokeMethodExpression.Accept() and confirm ExpressionStatement/InvokeMethodExpression visitor support#9907
Conversation
…clean up no-op assignments Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add remaining visit implementations for expressions and statements
Clean up InvokeMethodExpression.Accept() and confirm ExpressionStatement/InvokeMethodExpression visitor support
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the remaining visitor implementation work for
ExpressionStatementandInvokeMethodExpression— both were added in PR #7313 and are confirmed complete. Scoped per issue guidance to only these two types.Changes
InvokeMethodExpression.Accept(): Removed 6 redundant no-op self-assignments (invokeMethod.MethodName = invokeMethod.MethodName, etc.) that were left over from the initial implementation. OnlyInstanceReferenceandArgumentsneed updating since they are the visitable child nodes.@typespec/http-client-csharp.The visitor hooks (
VisitExpressionStatement,VisitInvokeMethodExpression) and their correspondingAcceptimplementations are fully functional with existing test coverage inExpressionVisitorTests.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.