fix: Remove evaluation metric key from schema which failed on some LLMs#105
Open
jsonbailey wants to merge 3 commits intomainfrom
Open
fix: Remove evaluation metric key from schema which failed on some LLMs#105jsonbailey wants to merge 3 commits intomainfrom
jsonbailey wants to merge 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the structured output schema and parsing contract for judge evaluations, which can affect compatibility with existing providers/models and downstream consumers of the judge response shape. Test updates reduce risk but runtime behavior may differ if any integrations still return the old
evaluationsobject.Overview
Updates judge structured-output handling to use a fixed schema
{ "evaluation": { "score", "reasoning" } }rather than generating a dynamicevaluationsobject keyed byevaluation_metric_key.Judgenow always builds the schema (no key parameter), parses only the singleevaluationpayload, and marks evaluations as failed when that object is missing/invalid; tests are updated accordingly and dynamic schema helper methods are removed.Written by Cursor Bugbot for commit 916df2a. This will update automatically on new commits. Configure here.