feat: convert dgrid-shim to self extracting resources#4531
Merged
GordonSmith merged 1 commit intohpcc-systems:mainfrom Feb 27, 2026
Merged
feat: convert dgrid-shim to self extracting resources#4531GordonSmith merged 1 commit intohpcc-systems:mainfrom
GordonSmith merged 1 commit intohpcc-systems:mainfrom
Conversation
10 tasks
There was a problem hiding this comment.
Pull request overview
This PR converts the dgrid-shim dependency from an external script tag requirement to a self-extracting resource that is bundled directly into the code, similar to how WASM files are handled in the project.
Changes:
- Implemented a new
sfxJSplugin to wrap JavaScript bundles as self-extracting resources - Removed external dgrid-shim script tag dependencies from HTML files across multiple packages
- Eliminated test setup code that manually loaded dgrid-shim before running tests
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/esbuild-plugins/src/sfx-wrapper.ts | Added wrapJS and sfxJS functions to create self-extracting JavaScript bundles |
| packages/dgrid/src/dgrid-shim.ts | Modified to inline dgrid-shim bundle and evaluate it at runtime instead of expecting external script |
| packages/dgrid/vite.config.ts | Updated build configuration to exclude dgrid-shim from external dependencies |
| packages/dgrid/tests/index.ts | Removed helper function that manually loaded dgrid-shim |
| packages/dgrid/tests/dgrid.browser.spec.ts | Removed dgrid-shim loading test setup and assertions |
| packages/dgrid2/vite.config.ts | Added production environment configuration |
| packages/dgrid2/index.html | Removed external dgrid-shim script tag and changed import to local source |
| packages/dgrid2/index-preview.html | New preview HTML file created |
| packages/eclwatch/tests/eclwatch.browser.spec.ts | Removed manual dgrid-shim loading and related test assertions |
| packages/composite/tests/composite.browser.spec.ts | Removed dgrid-shim loading setup |
| packages/timeline/tests/timeline.browser.spec.ts | Removed dgrid-shim loading setup |
| packages/other/tests/other.browser.spec.ts | Removed dgrid-shim loading setup |
| packages/map/tests/map.browser.spec.ts | Removed dgrid-shim loading setup |
| packages/util/tests/debounce.spec.ts | Adjusted timing thresholds in debounce tests |
| Multiple HTML files | Removed external dgrid-shim script tags from index.html and index-preview.html files |
| packages/composite/index.html | Modified setTimeout intervals for chart type changes |
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
0a0f5bb to
8860165
Compare
Member
Author
|
@jchambers-ln - this PR fixes one of the blockers preventing you from using the 3.x.x versions. |
jeclrsg
approved these changes
Feb 26, 2026
GordonSmith
added a commit
that referenced
this pull request
Feb 27, 2026
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to what we do for wasm files
Checklist:
Testing: