Skip to content

feat: update dgrid integration and add new index-preview for dgrid2#4530

Closed
GordonSmith wants to merge 1 commit intohpcc-systems:mainfrom
GordonSmith:COMPOSITE_DGRID2
Closed

feat: update dgrid integration and add new index-preview for dgrid2#4530
GordonSmith wants to merge 1 commit intohpcc-systems:mainfrom
GordonSmith:COMPOSITE_DGRID2

Conversation

@GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Feb 24, 2026

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith requested a review from Copilot February 24, 2026 10:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates composite and demo integrations to use @hpcc-js/dgrid2 and introduces a new preview HTML entrypoint for dgrid2.

Changes:

  • Switch composite’s table integration from @hpcc-js/dgrid to @hpcc-js/dgrid2 (including chart type mapping and dependency update)
  • Add packages/dgrid2/index-preview.html to support an importmap-based preview flow
  • Adjust demo/index pages and Vite config to align with the updated integration

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/dgrid2/vite.config.ts Adds a define override for process.env.NODE_ENV
packages/dgrid2/index.html Updates the module import path used by the quick test page
packages/dgrid2/index-preview.html Adds a new importmap-based preview page for dgrid2
packages/composite/tests/composite.browser.spec.ts Removes dgrid shim loading/assertion from browser tests
packages/composite/src/MultiChart.ts Switches dynamic imports/mappings from dgrid to dgrid2
packages/composite/package.json Replaces @hpcc-js/dgrid dependency with @hpcc-js/dgrid2
packages/composite/index.html Removes shim script and adjusts demo timing to exercise TABLE
packages/composite/index-preview.html Removes shim script and adjusts demo timing to exercise TABLE

@GordonSmith
Copy link
Member Author

Closing in favor of #4531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants