feat: update dgrid integration and add new index-preview for dgrid2#4530
Closed
GordonSmith wants to merge 1 commit intohpcc-systems:mainfrom
Closed
feat: update dgrid integration and add new index-preview for dgrid2#4530GordonSmith wants to merge 1 commit intohpcc-systems:mainfrom
GordonSmith wants to merge 1 commit intohpcc-systems:mainfrom
Conversation
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
There was a problem hiding this comment.
Pull request overview
Updates composite and demo integrations to use @hpcc-js/dgrid2 and introduces a new preview HTML entrypoint for dgrid2.
Changes:
- Switch composite’s table integration from
@hpcc-js/dgridto@hpcc-js/dgrid2(including chart type mapping and dependency update) - Add
packages/dgrid2/index-preview.htmlto support an importmap-based preview flow - Adjust demo/index pages and Vite config to align with the updated integration
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/dgrid2/vite.config.ts | Adds a define override for process.env.NODE_ENV |
| packages/dgrid2/index.html | Updates the module import path used by the quick test page |
| packages/dgrid2/index-preview.html | Adds a new importmap-based preview page for dgrid2 |
| packages/composite/tests/composite.browser.spec.ts | Removes dgrid shim loading/assertion from browser tests |
| packages/composite/src/MultiChart.ts | Switches dynamic imports/mappings from dgrid to dgrid2 |
| packages/composite/package.json | Replaces @hpcc-js/dgrid dependency with @hpcc-js/dgrid2 |
| packages/composite/index.html | Removes shim script and adjusts demo timing to exercise TABLE |
| packages/composite/index-preview.html | Removes shim script and adjusts demo timing to exercise TABLE |
Member
Author
|
Closing in favor of #4531 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: