Skip to content

fix: Improve prerelease version filtering and terminal detection #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobostay wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: Improve prerelease version filtering and terminal detection #1365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ elif [ "${VERSION}" = "prerelease" ]; then
echo "Error: git is required to install prerelease versions" >&2
exit 1
fi
VERSION="$(git ls-remote --tags https://github.com/github/copilot-cli | tail -1 | awk -F/ '{print $NF}')"
VERSION="$(git ls-remote --tags https://github.com/github/copilot-cli | grep -E '\-.*refs/tags/' | tail -1 | awk -F/ '{print $NF}')"
if [ -z "$VERSION" ]; then
echo "Error: Could not determine prerelease version" >&2
exit 1
Expand Down Expand Up @@ -149,7 +149,7 @@ if ! command -v copilot >/dev/null 2>&1; then
esac

# Prompt user to add to shell rc file (only if interactive)
if [ -t 0 ] || [ -e /dev/tty ]; then
if [ -t 0 ]; then
echo ""
printf "Would you like to add it to %s? [y/N] " "$RC_FILE"
if read -r REPLY </dev/tty 2>/dev/null; then
Expand Down