fix: Improve prerelease version filtering and terminal detection #1365
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues in the installation script (
install.sh):Issues Fixed
1. Prerelease Tag Filtering
Problem: When
VERSION="prerelease"was specified, the script usedtail -1to get the last tag from git ls-remote, but this could return any tag (stable or prerelease), not specifically a prerelease version.Why this is problematic:
v1.0.0), the script would install it even though the user requested a prereleaseSolution: Filter for tags containing
-(which indicates prerelease versions likev1.0.0-beta,v1.0.0-alpha, etc.):This ensures that
VERSION="prerelease"always installs an actual prerelease version.2. Terminal Detection
Problem: The script checked
[ -t 0 ] || [ -e /dev/tty ]to determine if running interactively.Why this is problematic:
[ -t 0 ]correctly checks if file descriptor 0 (stdin) is a terminal[ -e /dev/tty ]only checks if the/dev/ttydevice file exists, not if stdin is connected to itSolution: Use only
[ -t 0 ]which is the correct and standard way to check for terminal interactivity:Impact
Test plan
[ -t 0 ]check🤖 Generated with Claude Code