Skip to content

Rust: Fix bug in inferMethodCallTypeSelf #21297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paldepind merged 2 commits into from
Feb 10, 2026
+5 −6
Merged

Rust: Fix bug in inferMethodCallTypeSelf #21297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
109d802
Rust: Fix bug in `inferMethodCallTypeSelf`
hvitved Feb 9, 2026
6611978
Update rust/ql/lib/codeql/rust/internal/typeinference/DerefChain.qll
hvitved Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions rust/ql/lib/codeql/rust/internal/typeinference/DerefChain.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,12 @@ class DerefImplItemNode extends ImplItemNode {
Type resolveSelfTypeAt(TypePath path) { result = resolveImplSelfTypeAt(this, path) }

/**
* Holds if the target type of the dereference implemention mentions a type
* parameter at `path`.
* Holds if the target type of the dereference implementation mentions type
* parameter `tp` at `path`.
*/
pragma[nomagic]
predicate targetHasTypeParameterAt(TypePath path) {
this.getAssocItem("Target").(TypeAlias).getTypeRepr().(TypeMention).getTypeAt(path) instanceof
TypeParameter
predicate targetHasTypeParameterAt(TypePath path, TypeParameter tp) {
tp = this.getAssocItem("Target").(TypeAlias).getTypeRepr().(TypeMention).getTypeAt(path)
}

/** Gets the first type parameter of the type being implemented, if any. */
Expand Down
2 changes: 1 addition & 1 deletion rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2619,7 +2619,7 @@ private Type inferMethodCallTypeSelf(
not result instanceof TypeParameter
or
exists(TypePath pathToTypeParam, TypePath suffix |
impl.targetHasTypeParameterAt(pathToTypeParam) and
impl.targetHasTypeParameterAt(pathToTypeParam, selfParamType) and
path0 = pathToTypeParam.appendInverse(suffix) and
result = t0 and
path = selfPath.append(suffix)
Expand Down