Rust: Fix bug in inferMethodCallTypeSelf
#21297
Open
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a rare bug in Rust internal type inference by tightening how deref Target type parameters are identified and propagated in inferMethodCallTypeSelf.
Changes:
- Update
DerefImplItemNode.targetHasTypeParameterAtto bind and return the specificTypeParameterfound at aTypePath. - Adjust
inferMethodCallTypeSelfto use the refinedtargetHasTypeParameterAtpredicate with the expectedselfParamType.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll | Updates deref-based method-call self type inference to use the refined target type-parameter predicate. |
| rust/ql/lib/codeql/rust/internal/typeinference/DerefChain.qll | Refines targetHasTypeParameterAt predicate signature and updates its documentation comment. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug rarely triggers in practice, because we later restrict propagation of type information to cases where the receiver contains an explicit
UnknownType. However, we definitely still want to fix the bug.DCA is uneventful, but shows that some inconsistencies are fixed.