Skip to content

feat(client): implement retry logic for fetching chain state, block t… #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
akrem-chabchoub wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(client): implement retry logic for fetching chain state, block t… #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 44 additions & 3 deletions pkg/bee/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,12 +493,22 @@ func (c *Client) CreatePostageBatch(ctx context.Context, amount int64, depth uin
}

func (c *Client) GetOrCreateMutableBatch(ctx context.Context, postageTTL time.Duration, depth uint64, label string) (string, error) {
csr, err := c.api.Postage.GetChainState(ctx)
var csr api.ChainStateResponse
err := c.retryDo(ctx, "get chain state", func() error {
var e error
csr, e = c.api.Postage.GetChainState(ctx)
return e
})
if err != nil {
return "", fmt.Errorf("get chain state: %w", err)
}

blockTime, err := c.swapClient.FetchBlockTime(ctx, swap.WithOffset(1000))
var blockTime int64
err = c.retryDo(ctx, "fetch block time", func() error {
var e error
blockTime, e = c.swapClient.FetchBlockTime(ctx, swap.WithOffset(1000))
return e
})
if err != nil {
return "", fmt.Errorf("fetching block time: %w", err)
}
Expand All @@ -514,7 +524,12 @@ func (c *Client) GetOrCreateMutableBatch(ctx context.Context, postageTTL time.Du

c.log.Debugf("calculated mutable batch: amount '%d', label '%s', price '%d', block time '%d', ttl '%s'", amount, label, price, blockTime, postageTTL)

batches, err := c.PostageBatches(ctx)
var batches []api.PostageStampResponse
err = c.retryDo(ctx, "get postage batches", func() error {
var e error
batches, e = c.PostageBatches(ctx)
return e
})
if err != nil {
return "", fmt.Errorf("get postage batches: %w", err)
}
Expand All @@ -538,6 +553,32 @@ func (c *Client) GetOrCreateMutableBatch(ctx context.Context, postageTTL time.Du
return c.CreatePostageBatch(ctx, amount, depth, label, false)
}

const maxRetryBackoff = 30 * time.Second

func (c *Client) retryDo(ctx context.Context, op string, fn func() error) error {
var err error
for i := 0; i < c.retryCount; i++ {
if i > 0 {
backoff := time.Duration(1<<uint(i-1)) * time.Second
if backoff > maxRetryBackoff {
backoff = maxRetryBackoff
}
c.log.Warningf("%s: attempt %d/%d failed, retrying in %v: %v", op, i, c.retryCount, backoff, err)
select {
case <-ctx.Done():
return ctx.Err()
case <-time.After(backoff):
}
}

err = fn()
if err == nil {
return nil
}
}
return err
}

// PostageBatches returns the list of batches of node
func (c *Client) PostageBatches(ctx context.Context) ([]api.PostageStampResponse, error) {
return c.api.Postage.PostageBatches(ctx)
Expand Down