feat(client): implement retry logic for fetching chain state, block t…#571
Draft
akrem-chabchoub wants to merge 1 commit intomasterfrom
Draft
feat(client): implement retry logic for fetching chain state, block t…#571akrem-chabchoub wants to merge 1 commit intomasterfrom
akrem-chabchoub wants to merge 1 commit intomasterfrom
Conversation
…ime, and postage batches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry with backoff in GetOrCreateMutableBatch
Summary
Adds retry with exponential backoff for the read-only RPC/API calls inside
GetOrCreateMutableBatch. Transient failures (e.g. Bee API or Geth RPC briefly unavailable) no longer fail checks immediately and trigger false alerts.Problem
Checks that use postage (pt-pss, retrieval, pushsync, fileretrieval, etc.) call
GetOrCreateMutableBatch. That function talks to:GetChainState,PostageBatches) – the node may fail if its blockchain RPC is slow or downFetchBlockTime) – the RPC endpoint may hiccupA single transient failure on any of these causes the whole check to fail and alert, even though the issue is outside our code (RPC/chain temporarily unavailable).
What changed
retryDoinpkg/bee/client.go: exponential backoff (1s, 2s, 4s, 8s, 16s, capped at 30s), uses existingretryCount(default 5), respects context cancellation.GetOrCreateMutableBatch:GetChainStateFetchBlockTimePostageBatchesCreatePostageBatch(write) to avoid creating duplicate batches.Files touched
pkg/bee/client.goGetOrCreateMutableBatchusesretryDofor the three read calls; addedretryDoandmaxRetryBackoffconstantObserved impact
Addresses errors like:
When the RPC is briefly unavailable, the call is retried with backoff instead of failing the check on the first attempt.