This repository was archived by the owner on Nov 9, 2023. It is now read-only.
RFC: Remove callback from next return handlers#82
Draft
rekmarks wants to merge 7 commits intoremove-createAsyncMiddlewarefrom
Draft
RFC: Remove callback from next return handlers#82rekmarks wants to merge 7 commits intoremove-createAsyncMiddlewarefrom
rekmarks wants to merge 7 commits intoremove-createAsyncMiddlewarefrom
Conversation
rekmarks
changed the title
rekmarks
force-pushed
the
remove-createAsyncMiddleware
branch
from
aca7998 to
1d9f07c
Compare
rekmarks
commented
Jun 24, 2021
rekmarks
force-pushed
the
remove-createAsyncMiddleware
branch
from
2cdcf45 to
378a820
Compare
Contributor
|
This library has now been migrated into the core monorepo. This PR has been locked and this repo will be archived shortly. Going forward, releases of this library will only include changes made in the core repo.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: #81
nextreturn handlers can beasyncfunctions. They don't need a callback. This PR types them such that they can beasyncfunctions, and removes the "done" callback.