Skip to content

Fix mutating SQL assertion in Tool Store download #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendanx67 merged 1 commit into from
Mar 12, 2026
Merged

Fix mutating SQL assertion in Tool Store download #608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion SkylineToolsStore/src/org/labkey/skylinetoolsstore/SkylineToolsStoreController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,7 +1088,12 @@ else if (toolLsid != null &&
// Cookie expires after 1 day
final int expires = 24 * 60 * 60;

SkylineToolsStoreManager.get().recordToolDownload(tool);
// Download counter is an incidental write on a GET action — use ignoreSqlUpdates()
// to avoid the dev-mode mutating SQL assertion (like auditing writes)
try (var ignored = SpringActionController.ignoreSqlUpdates())
{
SkylineToolsStoreManager.get().recordToolDownload(tool);
}

DateFormat df = new SimpleDateFormat("EEE, dd-MMM-yyyy HH:mm:ss 'GMT'", Locale.US);
Calendar calendar = Calendar.getInstance();
Expand Down
Loading