Fix mutating SQL assertion in Tool Store download#608
Merged
brendanx67 merged 1 commit intorelease25.11-SNAPSHOTfrom Mar 12, 2026
Merged
Fix mutating SQL assertion in Tool Store download#608brendanx67 merged 1 commit intorelease25.11-SNAPSHOTfrom
brendanx67 merged 1 commit intorelease25.11-SNAPSHOTfrom
Conversation
* Wrapped recordToolDownload in ignoreSqlUpdates() for dev-mode compatibility Co-Authored-By: Claude <noreply@anthropic.com>
labkey-jeckels
approved these changes
Mar 12, 2026
vagisha
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recordToolDownload()inSpringActionController.ignoreSqlUpdates()to fix dev-mode assertion that blocks mutating SQL (UPDATE download counter) on GET request inDownloadToolActionReplaces #607 (which was incorrectly based on develop).
Test plan
Co-Authored-By: Claude noreply@anthropic.com