Skip to content

chore: ensure consistent HA DB timestamps #20398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
spypsy wants to merge 1 commit into
base: merge-train/spartan
Choose a base branch
from
Open

chore: ensure consistent HA DB timestamps #20398

spypsy wants to merge 1 commit into from
+250 −16

Conversation

@spypsy
Copy link
Member

@spypsy spypsy commented Feb 11, 2026 •
edited
Loading

Fixes A-543

Also add note to docs for users to know that they can't use the same DB for nodes running on different rollup versions

Follow-up from comments on #20060

@spypsy spypsy marked this pull request as ready for review February 11, 2026 15:33
PhilWindle
PhilWindle requested changes Feb 11, 2026
View reviewed changes
yarn-project/end-to-end/src/composed/ha/e2e_ha_full.test.ts Outdated
const diffSeconds = Math.abs(timestamp1 - timestamp2);

// Should be less than 1 second apart (not hours due to timezone interpretation)
expect(diffSeconds).toBeLessThan(1);
Copy link
Collaborator

@PhilWindle PhilWindle Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like a value this tight could cause flakey test runs.

Copy link
Member Author

@spypsy spypsy Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, updating. we just need to check it's not hours so can definitely be more tolerant

@spypsy spypsy mentioned this pull request Feb 11, 2026
Open
@AztecBot
Copy link
Collaborator

AztecBot commented Feb 11, 2026

⚠️ Docs Examples Validation Failed

TypeScript validation

(truncated)...
d/error-codes#yn0072---nm_preserve_symlinks_required�YN0072�]8;;�: │ The application uses portals and that's why �[96m--preserve-symlinks�[39m Node option is required for launching it
recursive_verification	�[94m➤�[39m �[90mYN0000�[39m: └ Completed
token_bridge	�[94m➤�[39m YN0000: · �[1mYarn 4.5.2�[22m
recursive_verification	�[93m➤�[39m YN0000: · Done with warnings in 0s 46ms
token_bridge	�[94m➤�[39m �[90mYN0000�[39m: ┌ Resolution step
token_bridge	�[94m➤�[39m �]8;;https://yarnpkg.com/advanced/error-codes#yn0085---updated_resolution_record�YN0085�]8;;�: │ �[32m+�[39m �[91m@aztec/�[39m�[91maccounts�[39m�[96m@�[39m�[96mlink:/home/aztec-dev/aztec-packages/yarn-project/accounts::locator=token_bridge%40workspace%3A.�[39m, and �[93m5�[39m more.
token_bridge	�[94m➤�[39m �[90mYN0000�[39m: └ Completed
token_bridge	�[94m➤�[39m �[90mYN0000�[39m: ┌ Fetch step
token_bridge	�[94m➤�[39m �[90mYN0000�[39m: └ Completed
token_bridge	�[94m➤�[39m �[90mYN0000�[39m: ┌ Link step
token_bridge	�[93m➤�[39m �]8;;https://yarnpkg.com/advanced/error-codes#yn0072---nm_preserve_symlinks_required�YN0072�]8;;�: │ The application uses portals and that's why �[96m--preserve-symlinks�[39m Node option is required for launching it
token_bridge	�[94m➤�[39m �[90mYN0000�[39m: └ Completed
recursive_verification	Verifying linked packages...
token_bridge	�[93m➤�[39m YN0000: · Done with warnings in 0s 50ms
recursive_verification	✓ @aztec/aztec.js: 76 .d.ts files
recursive_verification	✓ @aztec/accounts: 27 .d.ts files
recursive_verification	✓ @aztec/wallets: 10 .d.ts files
recursive_verification	✓ @aztec/kv-store: 70 .d.ts files
recursive_verification	✓ @aztec/pxe: 116 .d.ts files
recursive_verification	✓ @aztec/noir-contracts.js: 33 .d.ts files
recursive_verification	✓ @aztec/bb.js: 185 .d.ts files
recursive_verification	✓ @aztec/noir-noir_js: 5 .d.ts files
token_bridge	Adding npm deps: @aztec/viem@2.38.2
bob_token_contract	Type checking 'bob_token_contract'...
token_bridge	�[94m➤�[39m YN0000: · �[1mYarn 4.5.2�[22m
token_bridge	�[94m➤�[39m �[90mYN0000�[39m: ┌ Resolution step
token_bridge	�[94m➤�[39m �]8;;https://yarnpkg.com/advanced/error-codes#yn0085---updated_resolution_record�YN0085�]8;;�: │ �[32m+�[39m �[91m@aztec/�[39m�[91mviem�[39m�[96m@�[39m�[96mnpm:2.38.2�[39m, �[91m@adraffy/�[39m�[91mens-normalize�[39m�[96m@�[39m�[96mnpm:1.11.1�[39m, �[91m@noble/�[39m�[91mciphers�[39m�[96m@�[39m�[96mnpm:1.3.0�[39m, �[91m@noble/�[39m�[91mcurves�[39m�[96m@�[39m�[96mnpm:1.9.1�[39m, �[91m@noble/�[39m�[91mcurves�[39m�[96m@�[39m�[96mnpm:1.9.7�[39m, and �[93m10�[39m more.
token_bridge	�[94m➤�[39m �[90mYN0000�[39m: └ Completed in 0s 257ms
token_bridge	�[94m➤�[39m �[90mYN0000�[39m: ┌ Fetch step
recursive_verification	Type checking 'recursive_verification'...
token_bridge	�[94m➤�[39m �]8;;https://yarnpkg.com/advanced/error-codes#yn0013---fetch_not_cached�YN0013�]8;;�: │ �[93m15�[39m packages were added to the project (�[91m+ 33.13 MiB�[39m).
token_bridge	�[94m➤�[39m �[90mYN0000�[39m: └ Completed in 0s 913ms
token_bridge	�[94m➤�[39m �[90mYN0000�[39m: ┌ Link step
aztecjs_testing	✓ 'aztecjs_testing' validated successfully
aztecjs_testing	Cleaning up temporary files for 'aztecjs_testing'...
bob_token_contract	✓ 'bob_token_contract' validated successfully
bob_token_contract	Cleaning up temporary files for 'bob_token_contract'...
recursive_verification	index.ts(41,7): error TS2353: Object literal may only specify known properties, and 'dataDirectory' does not exist in type 'NodeEmbeddedWalletOptions'.
recursive_verification	index.ts(60,32): error TS2339: Property 'createAccount' does not exist on type 'NodeEmbeddedWallet'.
recursive_verification	ERROR: Type checking failed for 'recursive_verification'
recursive_verification	Validation failed for 'recursive_verification', cleaning up...
parallel: This job failed:
validate_project recursive_verification
Seq	Host	Starttime	JobRuntime	Send	Receive	Exitval	Signal	Command
2	:	1770833708.299	     4.654	0	1856	0	0	validate_project aztecjs_authwit
3	:	1770833708.302	     4.861	0	1988	0	0	validate_project aztecjs_connection
1	:	1770833708.297	     5.032	0	2080	0	0	validate_project aztecjs_advanced
4	:	1770833708.305	     5.136	0	1928	0	0	validate_project aztecjs_getting_started
5	:	1770833712.957	     3.441	0	1856	0	0	validate_project aztecjs_testing
6	:	1770833713.168	     3.917	0	1867	0	0	validate_project bob_token_contract
7	:	1770833713.334	     4.236	0	3574	1	0	validate_project recursive_verification
ERROR: Some project(s) failed validation

Action required: Please fix the docs examples or update them to match the current API.

cc @AztecProtocol/devrel

@spypsy
chore: ensure consistent HA DB timestamps
62e99e0 
Fixes [A-543](https://linear.app/aztec-labs/issue/A-543/ensure-no-timezone-issues-when-cleaning-up-old-duties)

Also add note to docs for users to know that they can't use the same DB for nodes running on different rollup versions

Follow-up from comments on #20060
@AztecBot AztecBot enabled auto-merge February 12, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilWindle PhilWindle PhilWindle requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spypsy @AztecBot @PhilWindle