Open
Conversation
PhilWindle
requested changes
Feb 11, 2026
| context: HAProtectedSigningContext, | ||
| signFn: (messageHash: Buffer32) => Promise<Signature>, | ||
| ): Promise<Signature> { | ||
| const startTime = Date.now(); |
Collaborator
There was a problem hiding this comment.
Do we not have a DateProvider?
Member
Author
There was a problem hiding this comment.
ah, hadn't used it in validator-ha-signer until now actually. will update
Member
Author
There was a problem hiding this comment.
I think better to add DateProvider after #20398 has gone in as it involves changes in timings that will conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes A-355
Also moves a bunch of types / interfaces from
validator-ha-signertostdlibto remove cyclic dependencies inyarn-project.It does make sense to not have
stdlibimportvalidator-ha-signer