Remove more model summary tests#79
Open
RasmusWL wants to merge 2 commits intoyoff:python/enable-summaries-from-modelsfrom
Open
Remove more model summary tests#79RasmusWL wants to merge 2 commits intoyoff:python/enable-summaries-from-modelsfrom
RasmusWL wants to merge 2 commits intoyoff:python/enable-summaries-from-modelsfrom
Conversation
For flow summaries, it's important that we have a store step.
Thinking some more about this, I think these tests should be about whether you can write flow summaries in CSV files that do the right thing. Having all these extra taint steps are closer to what our current taint-tracking does in the end, but from my point of view, doesn't help us achieve the goal of the tests. So, I'm removing them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking some more about this, I think these tests should be about
whether you can write flow summaries in CSV files that do the right
thing.
Having all these extra taint steps are closer to what our current
taint-tracking does in the end, but from my point of view, doesn't help
us achieve the goal of the tests.
So, I'm removing them.