Open
Conversation
JohanMabille
requested changes
Feb 4, 2026
test/test_xcomplex.cpp
Outdated
| EXPECT_TRUE(allclose(cmplexpected_angle, cmplres_angle)); | ||
|
|
||
| using assign_t_angle = xassign_traits<xarray<double>, decltype(cmplres_angle)>; | ||
| (void) sizeof(assign_t_angle); // to avoid unused warning |
Member
There was a problem hiding this comment.
Please move the definition where it is used instead of this horrible hack.
test/test_xcomplex.cpp
Outdated
| EXPECT_TRUE(allclose(cmplexpected_conj, cmplres_conj)); | ||
|
|
||
| using assign_t_conj = xassign_traits<xarray<std::complex<double>>, decltype(cmplres_conj)>; | ||
| (void) sizeof(assign_t_conj); // to avoid unused warning |
test/test_xcomplex.cpp
Outdated
| }; | ||
|
|
||
| using assign_t_norm = xassign_traits<xarray<double>, decltype(cmplres_norm)>; | ||
| (void) sizeof(assign_t_norm); // to avoid unused warning |
test/test_xcomplex.cpp
Outdated
| } | ||
|
|
||
| using assign_t_arg = xassign_traits<xarray<double>, decltype(cmplres)>; | ||
| (void) sizeof(assign_t_arg); // to avoid unused warning |
test/test_xreducer.cpp
Outdated
|
|
||
| #define TEST_VALUE_HAS_VALUE(INPUT, V_TYPE, OPTIONAL) \ | ||
| using result_type = std::conditional_t<OPTIONAL, xtl::xoptional<double>, double>; \ | ||
| (void) sizeof(result_type); \ |
Member
There was a problem hiding this comment.
This is not required since result_type is used just below.
test/test_xstrided_view.cpp
Outdated
| EXPECT_EQ(a, par); | ||
| } | ||
| using assign_traits = xassign_traits<xarray<double>, decltype(av)>; | ||
| (void) sizeof(assign_traits); // to avoid unused warning |
Member
There was a problem hiding this comment.
Please move the definition where it is used instead.
test/test_xview.cpp
Outdated
| // Suppress unused typedef warnings | ||
| (void) sizeof(ctes); | ||
| (void) sizeof(carr); | ||
| (void) sizeof(cfix); |
Member
There was a problem hiding this comment.
These 3 lines can be removed.
| auto vxa = view(xt::arange<double>(100), range(0, 10)); | ||
|
|
||
| using assign_traits = xassign_traits<decltype(vxt), decltype(b)>; | ||
| (void) sizeof(assign_traits); // suppress unused typedef warning |
Member
There was a problem hiding this comment.
Please move the definition where it is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description