Open
Conversation
Co-authored-by: FulgerX2007 <2111375+FulgerX2007@users.noreply.github.com>
Co-authored-by: FulgerX2007 <2111375+FulgerX2007@users.noreply.github.com>
Enhance the keyword search functionality to incorporate full URL text matching. The search operation should scan the complete URL string rather than limiting the search scope to only the URL prefix
--- updated-dependencies: - dependency-name: dompurify dependency-version: 3.2.4 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: postcss dependency-version: 8.5.6 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: webpack dependency-version: 5.99.9 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: xml2js dependency-version: 0.5.0 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: "@babel/runtime-corejs3" dependency-version: 7.27.6 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: "@babel/traverse" dependency-version: 7.27.7 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: json5 dependency-version: 1.0.2 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: jszip dependency-version: 3.10.1 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: "@ffflorian/jszip-cli" dependency-version: 3.8.5 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: loader-utils dependency-version: 2.0.4 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: loader-utils dependency-version: 2.0.4 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: serialize-javascript dependency-version: 6.0.2 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: tough-cookie dependency-version: 4.1.4 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: ws dependency-version: 7.5.10 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
…nd_yarn-48ddede0bd Bump the npm_and_yarn group across 1 directory with 14 updates
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances bookmark search behavior and refreshes several npm dependencies used by the app’s runtime and build tooling.
Changes:
- Update keyword-search scoring to include URL-derived keywords and allow substring (not just prefix) matches.
- Bump multiple dependencies in
package.json(and regeneratepackage-lock.json) includingdompurify,postcss,webpack,xml2js, and@ffflorian/jszip-cli.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/modules/shared/bookmark/bookmark-helper/bookmark-helper.service.ts |
Expands keyword extraction to include URL keywords and broadens matching from prefix to substring. |
package.json |
Updates dependency versions for security/features and build tooling. |
package-lock.json |
Lockfile updates reflecting new dependency graph/versions (including new engine requirements). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/modules/shared/bookmark/bookmark-helper/bookmark-helper.service.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to dependencies in
package.jsonand a functional change to theBookmarkHelperServiceclass inbookmark-helper.service.ts. The dependency updates ensure the project uses the latest versions of libraries, while the functional change enhances keyword-matching logic.Dependency Updates:
dompurifyto version^3.2.4for improved security and features.@ffflorian/jszip-clito version^3.8.5indevDependencies.postcssto version^8.5.6for better CSS processing.webpackto version^5.99.9andxml2jsto version^0.5.0for improved build performance and XML parsing capabilities.Functional Change:
BookmarkHelperServiceclass to:false, true) to thegetKeywordsFromBookmarkmethod for more refined keyword extraction.>= 0) instead of prefix matches (=== 0). This improves the flexibility of keyword matching.