Add build version to wavedash.toml and optional --message flag#11
Open
cloud9c wants to merge 1 commit intofeat/game-id-tomlfrom
Open
Add build version to wavedash.toml and optional --message flag#11cloud9c wants to merge 1 commit intofeat/game-id-tomlfrom
cloud9c wants to merge 1 commit intofeat/game-id-tomlfrom
Conversation
cloud9c
changed the title
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Move build version from CLI flag to wavedash.toml config file. The top-level `version` field is the build version sent to the API, while the engine section `version` remains the engine version. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cloud9c
force-pushed
the
feat/required-build-version
branch
from
299ab63 to
b2f6f97
Compare
cloud9c
changed the title
cloud9c
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versionfield towavedash.tomlfor the build version (e.g.version = "0.0.1")version()toengine_version()to disambiguate from build version--message/-mCLI flag tobuild pushfor per-push build messagesDesign
The build version lives in
wavedash.toml(not as a CLI flag) to keep a single source of truth — consistent with how npm, cargo, and other tools handle versioning. The--messageflag is CLI-only since messages are ephemeral per-push metadata.Test plan
wavedash.tomlwithoutversionfield errors onbuild pushbuild pushreadsversionfromwavedash.tomland sends it to the APIbuild push -m "my message"sends the build message to the API🤖 Generated with Claude Code