Skip to content

Conversation

@workos-sdk-automation
Copy link
Contributor

Summary

Reverts the VERSION extraction in release.yml from ${GITHUB_REF_NAME##*/v} back to ${GITHUB_REF_NAME#v}.

The ##*/v pattern requires a / before v to match, so with simple v6.1.0 tags (from the include-component-in-tag: false fix in #441), it returns the full v6.1.0 string instead of 6.1.0, causing gem push to look for pkg/workos-v6.1.0.gem instead of pkg/workos-6.1.0.gem.

Test plan

The `##*/v` pattern requires a `/` before `v` to match, so it doesn't
strip the `v` from simple `v6.1.0` tags. Now that tags use `v6.1.0`
format, the original `#v` pattern is correct.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@workos-sdk-automation workos-sdk-automation bot requested a review from a team as a code owner February 10, 2026 19:33
@workos-sdk-automation workos-sdk-automation bot requested review from gjtorikian and removed request for a team February 10, 2026 19:33
@greptile-apps
Copy link

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR correctly reverts the VERSION extraction pattern in the release workflow from ${GITHUB_REF_NAME##*/v} back to ${GITHUB_REF_NAME#v}. The ##*/v pattern requires a / before v to match, which doesn't work with simple v6.1.0 tags (only with full refs like refs/tags/v6.1.0). This revert ensures the gem publish step looks for pkg/workos-6.1.0.gem instead of incorrectly searching for pkg/workos-v6.1.0.gem.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is a simple, well-understood revert of a bash parameter expansion pattern that fixes a broken gem publishing workflow. The fix correctly handles simple v-prefixed tags (e.g., v6.1.0) by using #v instead of ##*/v. No security concerns, no logic errors, and the change is essential for unblocking releases.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/release.yml Reverted VERSION extraction from ##*/v to #v to correctly handle simple v-prefixed tags (e.g., v6.1.0)

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gjtorikian gjtorikian merged commit 56f1a48 into main Feb 10, 2026
5 checks passed
@gjtorikian gjtorikian deleted the fix-version-extraction branch February 10, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant