Skip to content

fix: use simple v-prefixed tags and fix gem publish path #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gjtorikian merged 1 commit into from
Feb 10, 2026
+3 −2
Merged

fix: use simple v-prefixed tags and fix gem publish path #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ jobs:

- name: Publish to RubyGems
run: |
VERSION="${GITHUB_REF_NAME#v}"
VERSION="${GITHUB_REF_NAME##*/v}"
bundle exec rake build
gem push pkg/workos-${VERSION}.gem --host https://rubygems.org
Comment on lines +38 to 40
Copy link

@greptile-apps greptile-apps bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERSION parsing breaks v-tags

VERSION="${GITHUB_REF_NAME##*/v}" only strips the prefix when the ref name contains a path segment ending in /v (e.g. workos/v6.1.0). For the intended new tag format v6.1.0, this leaves VERSION as v6.1.0, so the workflow will try to gem push pkg/workos-v6.1.0.gem (which won’t exist if the built gem is pkg/workos-6.1.0.gem). To support both formats, VERSION needs to normalize both vX.Y.Z and */vX.Y.Z to X.Y.Z.

3 changes: 2 additions & 1 deletion release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"release-type": "ruby",
"package-name": "workos",
"version-file": "lib/workos/version.rb",
"changelog-path": "CHANGELOG.md"
"changelog-path": "CHANGELOG.md",
"include-component-in-tag": false
}
}
}