Skip to content

Add docker services health-check script#863

Open
kitcommerce wants to merge 1 commit intonextfrom
kit/860-docker-services-health
Open

Add docker services health-check script#863
kitcommerce wants to merge 1 commit intonextfrom
kit/860-docker-services-health

Conversation

@kitcommerce
Copy link

Closes #860.

Adds a lightweight, read-only preflight script to verify the required docker services are running before tests.

Usage:

  • ./script/docker_services_health

Client impact:

  • None expected

@kitcommerce kitcommerce added gate:build-pending Build gate running gate:build-passed Build gate passed review:architecture-pending Review in progress review:simplicity-pending Review in progress review:security-pending Review in progress review:rails-conventions-pending Rails conventions review in progress review:architecture-done Review complete review:simplicity-done Review complete review:security-done Review complete review:rails-conventions-done Rails conventions review complete and removed gate:build-pending Build gate running review:architecture-pending Review in progress review:simplicity-pending Review in progress review:security-pending Review in progress review:rails-conventions-pending Rails conventions review in progress labels Mar 10, 2026
@kitcommerce
Copy link
Author

Wave 1 Reviews (Foundation)

Architecture — PASS_WITH_NOTES (LOW)

  • Note: fuzzy container/image-name matching could false-positive on unrelated containers.
  • Note: system_prereqs combines install + verify responsibilities (acceptable for now).

Security — PASS_WITH_NOTES (LOW)

  • Note: sudo apt-get install now lives in a script executed from the branch (same risk profile as previous inline step).
  • Note: fuzzy container matching is a tooling false-positive risk, not exploitable.

Simplicity — PASS_WITH_NOTES (LOW)

  • Note: --verify mode in system_prereqs is not invoked by CI in this PR.
  • Note: fuzzy matching fallback in docker_services_health may be speculative; exact-name match might be enough.

Rails conventions — PASS

  • No Rails/Ruby code touched; dev tooling only.

@kitcommerce kitcommerce added review:rails-security-pending Rails security review in progress review:database-pending Database review in progress review:test-quality-pending Review in progress review:test-quality-done Review complete review:database-done Database review complete and removed review:test-quality-pending Review in progress review:rails-security-pending Rails security review in progress review:database-pending Database review in progress labels Mar 10, 2026
@kitcommerce
Copy link
Author

Database Review

Verdict: PASS

No database-related changes in this PR (developer tooling + CI scripts only).

@kitcommerce
Copy link
Author

Security Review

Verdict: PASS_WITH_NOTES

  • sudo apt-get install is now in a branch-executed script (same risk profile as previous inline CI step; just less visible).
  • Fuzzy container matching in the docker health check is a false-positive risk, not an exploit vector.

@kitcommerce
Copy link
Author

Test/CI Quality Review

Verdict: CHANGES_REQUIRED

CI is failing fast across most jobs, consistent with an early prerequisites failure. This PR also bundles system_prereqs + workflow changes that belong to issue #859 / PR #864.

Requested: scope this PR to script/docker_services_health only (remove script/system_prereqs + .github/workflows/ci.yml changes), then re-run CI.

@kitcommerce kitcommerce force-pushed the kit/860-docker-services-health branch from 412a1db to 2f1c7cb Compare March 10, 2026 02:36
@kitcommerce kitcommerce added gate:build-failed Build gate failed and removed gate:build-passed Build gate passed labels Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gate:build-failed Build gate failed review:architecture-done Review complete review:database-done Database review complete review:rails-conventions-done Rails conventions review complete review:security-done Review complete review:simplicity-done Review complete review:test-quality-done Review complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant