Draft
Conversation
d8fda66 to
6fe5338
Compare
Member
Author
|
Rebased on the latest release. Linter fails and suggests to add |
6fe5338 to
1f5ea03
Compare
|
I'm really looking forward to Android 4 compatibility because the Tolino Shine 3 only runs on Android 4.4.2. |
Member
Author
|
@tristan-k there's nothing to look forward to - this PR is not going to be merged. You can build the app from this branch yourself - just use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notice: minimum Android version requirement is not going to be lowered from Android 5 in the official app, but this branch can be built and used by those who need it.
I wanted to know which things are compatible with Android 4 and how hard it is to maintain compatibility.
Not worth it. So the remaining legacy version checks should be removed from master.
Tested on Android 4.0.3 emulator (API 15).
There's a security issue with JavaScript having access to any Java methods (not only specifically annotated to work with JS) on the injected into WebView objects on Android <4.2.
WebView:
window.getSelection()seems to not work (maybe an emulator issue, though). Maybe workarounds are possible, haven't checked it. As a result:Full-text-search is enabled only since Android 4.1. Android 4.0 uses the old title-based search.
TTS: parsing seems to work, didn't check the work with TTS engines. Guaranteed degraded fast-forward/rewind functionality on Android <4.0.3.
This branch is updated with force-pushes. Backups of the previous versions: 2.4.2.