-
Notifications
You must be signed in to change notification settings - Fork 9
Asset class #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Asset class #417
Conversation
|
@kjano @KathiSchleidt @sgrellet @afeliachi Can you check that this accomplishes what we discussed. |
sgrellet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Two questions from my end
- if we have hasDeployment - deployedAsset. Why keeping inDeployment/deployedOnPlatform ? and systemDeployment/deployedSystem ? for backward compatibility ?
- same with hosts/isHostedBy => a recursive association (hosts/isHostedBy) on Assest with help removing the other two
maximelefrancois86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good proposal, just a few minor change requests
ssn/chapters/Common.html
Outdated
| Asset MUST be considered to be abstract, so any individual Asset SHOULD be declared to be an | ||
| instance of a concrete sub-class, and not of the Asset class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UML world... Abstract classes don't exist in RDF and OWL. I suggest removing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already had this form of words for Execution and System.
Yes, this is 'UML-ish' but here it is just normative text.
I don't know how to write an axiom that rdf:type sosa:Asset must not appear.
(It can probably be done in SHACL, of course)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
There are two provisions here: (one uses MUST, one uses SHOULD).
The second one can be checked/enforced with ex. SHACL, but the first one cannot (how something is considered is in the head of the user, not in the implementation). So I would suggest to use a different formulation like:
Asset are considered abstract. Entities SHOULD NOT be explicitly typed as
an Asset, unless they are typed with one of the (concrete) sub-classes of Asset.
Maybe this can be part of a separate issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it to
The Asset class is considered to be abstract. An individual SHOULD NOT be typed as an Asset, but MAY be typed with one of the (concrete) sub-classes of Asset.
Yes, this still has two normative provisions, but in my opinion they belong together.
Also changed Execution and System to match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(or should it be MUST NOT rather than SHOULD NOT)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer SHOULD NOT.
Many OWL APIs have the option to explicit inferred triples. Saying MUST NOT would imply that we forbid users to use these tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. The provision applies to assertions, not to inferences. Let's try to make that clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just
The Asset class is considered to be abstract. Individual assets SHOULD be typed with one of the (concrete) sub-classes of Asset
some after thoughts, with such a high level recursive association, if we still want to keep the |
ssn/chapters/Common.html
Outdated
| Asset MUST be considered to be abstract, so any individual Asset SHOULD be declared to be an | ||
| instance of a concrete sub-class, and not of the Asset class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
There are two provisions here: (one uses MUST, one uses SHOULD).
The second one can be checked/enforced with ex. SHACL, but the first one cannot (how something is considered is in the head of the user, not in the implementation). So I would suggest to use a different formulation like:
Asset are considered abstract. Entities SHOULD NOT be explicitly typed as
an Asset, unless they are typed with one of the (concrete) sub-classes of Asset.
Maybe this can be part of a separate issue.
# Conflicts: # ssn/chapters/Common.html
Align definitions of the other abstract classes and properties.
Closes #416
Preview https://raw.githack.com/w3c/sdw-sosa-ssn/416-asset-class/ssn/index.html#Systems-and-their-Deployment