Revert "Allow setting python::version in hiera to Integer"#745
Open
Revert "Allow setting python::version in hiera to Integer"#745
python::version in hiera to Integer"#745Conversation
Contributor
|
Why revert this? It works and doesn't break anything, having graceful input handling is a good improvement! |
Member
Author
Consistency and correctness? Hence the request to revert this and only accept a version number as a String. |
kenyon
approved these changes
Jan 27, 2026
traylenator
approved these changes
Feb 5, 2026
Contributor
|
Versions are strings. If you want to really want to accept an integer in hiera you can possibly add: lookup_options:
python::version:
convert_to: "String"to your own hiera. but just quote the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #733 following discussions in #733 (comment)