Update base image in Dockerfile from ubuntu:24.04 to ubuntu:25.04#10
Update base image in Dockerfile from ubuntu:24.04 to ubuntu:25.04#10
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughDockerfile updated: base image changed from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This fails with: Previous we could install dotnet-sdk-8.0, but dotnet-sdk-9.0 did not solve it this time - we can install |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(2 hunks)
🔇 Additional comments (1)
Dockerfile (1)
29-33:apt-get install -fcannot heal missing ICU—script exits non-zero, layer stays broken.Guard the install with
set -e(already via SHELL) and validate the dependency upfront, or bail out early:-dpkg -i powershell.deb && \ -apt-get update && apt-get install -f -y --no-install-recommends && \ +if ! dpkg -i powershell.deb; then \ + echo "⚠️ PowerShell .deb failed – attempting to resolve deps"; \ + apt-get update && apt-get install -f -y --no-install-recommends; \ +fi && \
Dockerfile
Outdated
| FROM ubuntu:25.04 | ||
| LABEL org.opencontainers.image.source="https://github.com/viscalyx/devshell-dsc" \ | ||
| org.opencontainers.image.description="Dockerized Ubuntu 24.04 dev environment with Zsh (Oh My Zsh & Powerlevel10k), PowerShell & DSC v3 pre-configured for seamless developer workflows." \ |
There was a problem hiding this comment.
Base image bump to 25.04 introduces unresolved ABI breakage & package-availability risks.
• 25.04 (a non-LTS development release) has already dropped libicu{52-74} that PowerShell 7.5.2 hard-depends on, so the image currently fails to build.
• dotnet-sdk-9.0 packages are not yet published for 25.04 in Microsoft’s APT feed; the install step will 404.
Unless you have a strict requirement for 25.04, consider reverting to 24.04/24.10 or pinning 25.04 and vendor the missing binaries.
-FROM ubuntu:25.04
+FROM ubuntu:24.04 # keep LTS until upstream packages exist📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| FROM ubuntu:25.04 | |
| LABEL org.opencontainers.image.source="https://github.com/viscalyx/devshell-dsc" \ | |
| org.opencontainers.image.description="Dockerized Ubuntu 24.04 dev environment with Zsh (Oh My Zsh & Powerlevel10k), PowerShell & DSC v3 pre-configured for seamless developer workflows." \ | |
| FROM ubuntu:24.04 # keep LTS until upstream packages exist | |
| LABEL org.opencontainers.image.source="https://github.com/viscalyx/devshell-dsc" \ | |
| org.opencontainers.image.description="Dockerized Ubuntu 24.04 dev environment with Zsh (Oh My Zsh & Powerlevel10k), PowerShell & DSC v3 pre-configured for seamless developer workflows." \ |
🤖 Prompt for AI Agents
In the Dockerfile at lines 3 to 5, the base image is set to Ubuntu 25.04, which
causes build failures due to missing dependencies and unavailable packages. To
fix this, revert the base image to Ubuntu 24.04 or 24.10 to ensure compatibility
with PowerShell 7.5.2 and availability of dotnet-sdk-9.0 packages. Update the
FROM line accordingly to use a supported LTS or near-LTS version.
Dockerfile
Outdated
| FROM ubuntu:24.10 | ||
| FROM ubuntu:25.04 | ||
| LABEL org.opencontainers.image.source="https://github.com/viscalyx/devshell-dsc" \ | ||
| org.opencontainers.image.description="Dockerized Ubuntu 24.04 dev environment with Zsh (Oh My Zsh & Powerlevel10k), PowerShell & DSC v3 pre-configured for seamless developer workflows." \ |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Label still claims “Ubuntu 24.04” – update to avoid misleading metadata.
- org.opencontainers.image.description="Dockerized Ubuntu 24.04 dev environment ...
+ org.opencontainers.image.description="Dockerized Ubuntu 25.04 dev environment ...🏁 Script executed:
#!/bin/bash
# Locate the Dockerfile and inspect the base image and description label
dockerfile=$(fd --type f --max-depth 2 --hidden --exact-depth 1 Dockerfile || echo "Dockerfile")
rg -n '^FROM ' "$dockerfile"
rg -n 'org.opencontainers.image.description' "$dockerfile"Length of output: 606
Update image description to match Ubuntu 25.04
The org.opencontainers.image.description label still references “Ubuntu 24.04,” but the FROM line uses ubuntu:25.04, which will confuse consumers. Please update the description to reflect Ubuntu 25.04.
- File: Dockerfile, line 5
- Change:
- org.opencontainers.image.description="Dockerized Ubuntu 24.04 dev environment with Zsh (Oh My Zsh & Powerlevel10k), PowerShell & DSC v3 pre-configured for seamless developer workflows." \
+ org.opencontainers.image.description="Dockerized Ubuntu 25.04 dev environment with Zsh (Oh My Zsh & Powerlevel10k), PowerShell & DSC v3 pre-configured for seamless developer workflows." \📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| org.opencontainers.image.description="Dockerized Ubuntu 24.04 dev environment with Zsh (Oh My Zsh & Powerlevel10k), PowerShell & DSC v3 pre-configured for seamless developer workflows." \ | |
| org.opencontainers.image.description="Dockerized Ubuntu 25.04 dev environment with Zsh (Oh My Zsh & Powerlevel10k), PowerShell & DSC v3 pre-configured for seamless developer workflows." \ |
🤖 Prompt for AI Agents
In Dockerfile at line 5, the org.opencontainers.image.description label mentions
"Ubuntu 24.04" while the base image is ubuntu:25.04. Update the description text
to replace "Ubuntu 24.04" with "Ubuntu 25.04" to ensure consistency and avoid
confusion.
| zsh git curl wget ca-certificates locales lsb-release fontconfig dotnet-sdk-9.0 sudo vim libicu76 \ | ||
| openssh-client && \ | ||
| locale-gen en_US.UTF-8 && \ |
There was a problem hiding this comment.
🛠️ Refactor suggestion
libicu76 does not satisfy PowerShell’s dependency list (≤ 74). Build will continue to fail.
Instead of adding an unused library, install a compatible version (e.g. libicu74) or ship a private copy:
- fontconfig dotnet-sdk-9.0 sudo vim libicu76 \
+ fontconfig sudo vim \
+# Temporarily fetch libicu74 from previous release until PowerShell supports 76
+ wget -qO- http://archive.ubuntu.com/ubuntu/pool/main/i/icu/libicu74_74.2-1_amd64.deb > /tmp/libicu74.deb && \
+ dpkg -i /tmp/libicu74.deb && rm /tmp/libicu74.deb && \
+ dotnet-sdk-8.0 \(Replace with a more robust mirror/pinning strategy as desired.)
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In the Dockerfile around lines 20 to 22, the package `libicu76` is incompatible
with PowerShell's dependency requirements, causing build failures. Replace
`libicu76` with a compatible version such as `libicu74` to satisfy PowerShell
dependencies. Alternatively, consider including a private copy of the required
library or implement a more robust package version pinning or mirror strategy to
ensure compatibility and build stability.
|
We move to 26.04 LTS when it releases instead, closing this. |
1 participant
This change is