feat(rm): add localized prompt messages for interactive mode#9838
Open
mattsu2020 wants to merge 8 commits intouutils:mainfrom
Open
feat(rm): add localized prompt messages for interactive mode#9838mattsu2020 wants to merge 8 commits intouutils:mainfrom
mattsu2020 wants to merge 8 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Add translations for rm command prompts in English and French, and update Linux-specific code to use localized strings instead of hardcoded messages, improving internationalization support.
Break long prompt_yes! macro invocations into multiple lines in the handle_writable_directory function to improve code readability and adhere to formatting standards. No functional changes.
GNU rm does not check for write-protection on symbolic links; it instead prompts to "remove symbolic link" regardless of the link's permissions or its target's status. This change: - Ensures `prompt_file` checks for symlinks specifically using `symlink_metadata`, avoiding the incorrect "write-protected" prompt. - Refactors permission checks into `is_writable_metadata` to allow using the already-fetched metadata, which also optimizes performance by reducing redundant `stat` calls. - Updates `prompt_file_permission_readonly` to operate on metadata directly.
Add translations for rm command prompts in English and French, and update Linux-specific code to use localized strings instead of hardcoded messages, improving internationalization support.
|
GNU testsuite comparison: |
The `is_writable` function was unused and has been removed to clean up the codebase. The logic has been simplified by keeping only the necessary `is_writable_metadata` function, which is now the single source of truth for checking writable permissions. This change reduces code duplication and improves maintainability.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add translations for rm command prompts in English and French, and update Linux-specific code to use localized strings instead of hardcoded messages, improving internationalization support.
related
#9824