sort: fix panic when collator not available in worker threads#10915
Open
sylvestre wants to merge 1 commit intouutils:mainfrom
Open
sort: fix panic when collator not available in worker threads#10915sylvestre wants to merge 1 commit intouutils:mainfrom
sylvestre wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
ChrisDryden
reviewed
Feb 13, 2026
| left.cmp(right) | ||
| } else { | ||
| // Fall back to byte comparison if collator is not available | ||
| COLLATOR |
Collaborator
There was a problem hiding this comment.
I think this is a good change to make for being more resilient, but I think the actual error is in the:
.is_some_and(|enc| enc.to_lowercase() == "utf-8")
Where we should probably modify it to also accept without the hyphen:
.is_some_and(|enc| {
let lower = enc.to_lowercase();
lower == "utf-8" || lower == "utf8"
})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10909