date: Fix format optional argument to capture all following parameters#10914
Open
cerdelen wants to merge 1 commit intouutils:mainfrom
Open
date: Fix format optional argument to capture all following parameters#10914cerdelen wants to merge 1 commit intouutils:mainfrom
cerdelen wants to merge 1 commit intouutils:mainfrom
Conversation
Collaborator
|
Was doing an investigation into why this was added in the first place: in #9661 Turns out I added it It appears that finding unknown arguments would trigger exit() directly so I added that as an attempt to fix that, but then I ended up making the whole thing return a result. LGTM, just waiting on the CI |
ChrisDryden
approved these changes
Feb 13, 2026
|
GNU testsuite comparison: |
Contributor
Author
|
This also doesn't fix all problems with arguments parsing, but it fixes this false negative at least. If i just try for example But this is for another pr i'd argue as this PR already fixes a valid way of using date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the format argument to capture all following parameters. Also added a regression test.
Fix: #10910