mv: preserve ownership and permissions on cross-partition moves#10899
Open
ChrisDryden wants to merge 1 commit intouutils:mainfrom
Open
mv: preserve ownership and permissions on cross-partition moves#10899ChrisDryden wants to merge 1 commit intouutils:mainfrom
ChrisDryden wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before reading this PR its clear to me that with the way mv is structured there are 6 different fallback mechanisms and they need to all be fixed. This PR specifically addresses the missing functionality for the
tests/mv/meta-to-xpart.shgnu test. Similar logic needs to be applied to the other fallback paths but I think it would be best to do it more incrementally since we are actually missing some fallback paths (e.g. sparse file fallback)