fix(cp): add temporary write/exec perm to built dirs #10859
Closed
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my4ng
changed the title
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Collaborator
|
I ran an strace on the example and saw that that the reference implementation copies the files in the reverse order but when I was trying to see with a bunch of different permission sets it didn't seems to have any deviation in output so it looks like its correct |
ChrisDryden
reviewed
Feb 11, 2026
tests/by-util/test_cp.rs
Outdated
| .arg("test-dir-copy") | ||
| .succeeds(); | ||
|
|
||
| assert_eq!(at.metadata("test-dir").permissions().mode() & 0o777, 0o500); |
Collaborator
There was a problem hiding this comment.
I think the goal here would be to check the permissions of the test-dir-copy not the test-dir right?
Contributor
Author
There was a problem hiding this comment.
Yep should have checked test-dir-copy instead, my bad
Contributor
Author
|
superseded by #10904. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10787 by granting temporary u+wx permission when building directory while preserving attributes. The true permission is set
dirs_needing_permissionslater.Add test case for the issue.