Conversation
|
GNU testsuite comparison: |
This comment was marked as resolved.
This comment was marked as resolved.
|
GNU testsuite comparison: |
|
some jobs are failing |
|
GNU testsuite comparison: |
|
@sylvestre, @oech3, now CI is passing. Should I add test with |
| use std::borrow::Cow; | ||
| use std::ffi::CStr; | ||
| use std::fmt::Write; | ||
| use std::io::{self, Write as _}; |
There was a problem hiding this comment.
please remove the "as _"
There was a problem hiding this comment.
Then it would conflict with use std::fmt::Write;:
error[E0252]: the name `Write` is defined multiple times
--> src/uu/who/src/platform/unix.rs:21:21
|
20 | use std::fmt::Write;
| --------------- previous import of the trait `Write` here
21 | use std::io::{self, Write};
| ^^^^^ `Write` reimported here
|There was a problem hiding this comment.
ok, just remove the declaration then ?!
There was a problem hiding this comment.
No. needed for std{out,err}.
|
GNU testsuite comparison: |
|
@sylvestre, @oech3, please, take a look at this failing job: https://github.com/uutils/coreutils/actions/runs/21943316553/job/63375199339?pr=10801 Is it CI runner error? |
|
looks network err? |
|
GNU testsuite comparison: |
| } | ||
| println!("{}", buf.trim_end()); | ||
| let mut stdout = io::stdout().lock(); | ||
| writeln!(stdout, "{}", buf.trim_end()).map_err_context(|| translate!("who-write-error"))?; |
There was a problem hiding this comment.
This locale string doesn't exist it appears
| &comment, | ||
| "", | ||
| ); | ||
| )?; |
There was a problem hiding this comment.
Mind just removing the semicolon in these cases instead of doing the ? Ok(). It appears this is the only result function being returned here
| write!(buf, " {exit:<12}").unwrap(); | ||
| } | ||
| println!("{}", buf.trim_end()); | ||
| let mut stdout = io::stdout().lock(); |
There was a problem hiding this comment.
Whats the reason for using the lock here if its only for one write?
4 participants
Fixes #10550