Split generated file into multiple files, separating static code from generated code#86
Merged
Manishearth merged 14 commits intomasterfrom Feb 19, 2026
Merged
Split generated file into multiple files, separating static code from generated code#86Manishearth merged 14 commits intomasterfrom
Manishearth merged 14 commits intomasterfrom
Conversation
Manishearth
force-pushed
the
tests-split
branch
3 times, most recently
from
7ac9666 to
88a4d0e
Compare
Manishearth
changed the title
Manishearth
force-pushed
the
tests-split
branch
from
1f3447d to
d7a55a5
Compare
Manishearth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've split the massive tables.rs into:
Furthermore I've replaced some of the duplicated functions with a single function that has a const generic.
This means that most of the code in this crate is no longer within python docstrings, and it's all a bit more organized and readable.
n.b. I tried out gemini-cli for most of the gruntwork here, giving it a detailed idea of what code needed to go where and asking it to figure out the rest. Seemed to work fine, and I've reviewed the diffs.
Fixes #85