Skip to content

Comments

39 bug submit request button not working for request retrieval#40

Merged
Nealium104 merged 3 commits intomainfrom
39-bug-submit-request-button-not-working-for-request-retrieval
Feb 19, 2026
Merged

39 bug submit request button not working for request retrieval#40
Nealium104 merged 3 commits intomainfrom
39-bug-submit-request-button-not-working-for-request-retrieval

Conversation

@Nealium104
Copy link
Contributor

fixes #39. There is another half of this fix in the euk branch of ukl-ansible-playbooks which is already in production.

Changes

  1. Routing conflict changed in ukl-ansible-playbooks
    The config for exploreuk in production was redirecting all php requests for findingaid to index.php. When the client-side application requested public/date.php, it was redirecting to public/index.php, thus responses would be treated as a request for the default page and return the index.mustache component. Dev did not have this problem because it uses a nginx different configuration to combine findingaid and exploreuk-web-app.
  2. Dead code cleanup
    The functionality that date.php provided is, as far as I can tell, not needed at this time. There was a comment in /app/assets/js/requests.js that had this removal marked as a todo. There are a few fields being preserved, but the actual functionality is dead code and is trimmed here.

commit history note: I was finished with a client-side rework when I realized much of this was dead code, so there is a commit with this rework and an immediate deletion.

@Nealium104 Nealium104 linked an issue Feb 5, 2026 that may be closed by this pull request
@Nealium104 Nealium104 requested a review from cokernel February 6, 2026 13:11
@Nealium104 Nealium104 marked this pull request as ready for review February 6, 2026 13:41
@Nealium104 Nealium104 requested a review from a team as a code owner February 6, 2026 13:41
Copy link
Member

@cokernel cokernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. The datepicker has been intended to be removed for a while.

@Nealium104 Nealium104 merged commit f097420 into main Feb 19, 2026
2 of 3 checks passed
@Nealium104 Nealium104 deleted the 39-bug-submit-request-button-not-working-for-request-retrieval branch February 19, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Submit Request button not working for Request Retrieval

3 participants