Open
Conversation
f062727 to
f7bbe15
Compare
…radius in PlasmaExhaust class
…ric in PlasmaExhaust class
a4ce96b to
87e20e8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4096 +/- ##
==========================================
+ Coverage 46.88% 46.91% +0.02%
==========================================
Files 136 137 +1
Lines 29253 29280 +27
==========================================
+ Hits 13715 13736 +21
- Misses 15538 15544 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…_information and update physics calculations
…ing and add references for EU DEMO metric calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
PlasmaExhaustclass to encapsulate plasma exhaust calculations and refactors the codebase to use this class for computing key divertor and separatrix power metrics. It also updates variable names and output handling for consistency and clarity, and updates related plotting and metadata. The changes improve modularity and maintainability of the plasma physics calculations, and ensure that important exhaust-related metrics are consistently calculated and reported.Core Physics Refactor and New Calculations
PlasmaExhaustclass (process/models/physics/exhaust.py) to handle calculations for separatrix power, separatrix power per major radius, and the EU DEMO divertor protection metric, with references and documentation for each calculation.Physicsclass (process/models/physics/physics.py) to use the newPlasmaExhaustclass for all relevant calculations, updating the initialization and the main physics routine to delegate toPlasmaExhaustmethods.Variable and Output Handling
physics_variables.pyfor the new metrics (p_plasma_separatrix_rmajor_mw,p_div_bt_q_aspect_rmajor_mw), updated their initialization, and ensured they are included in the variable setup.Plotting and Metadata
plot_proc.py.Testing
PlasmaExhaustclass in both tokamak and stellarator test suites, ensuring the new structure is tested.Checklist
I confirm that I have completed the following checks: