docs: add design document for precommit handler integration#136
Merged
Conversation
Add a design document exploring how to integrate the Navigation API's precommitHandler feature into @funstack/router. Covers route-level precommit functions, global onPrecommit callback, execution semantics, interaction with existing features, and browser compatibility. https://claude.ai/code/session_01VQssND6WbN5jHEqYT1kWGj
…level execution
- Remove the proposed `onPrecommit` Router prop; users can register
global precommit handlers via the existing `onNavigate` callback
using `event.intercept({ precommitHandler })`.
- Change execution model from deepest-match-only to all-matches
sequential (parent → child), with short-circuiting on redirect.
- Add nested auth guard example and contrast with action semantics.
- Reduce files-to-change footprint (no Router/Adapter signature changes).
https://claude.ai/code/session_01VQssND6WbN5jHEqYT1kWGj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a design document exploring how to integrate the Navigation API's
precommitHandler feature into @funstack/router. Covers route-level
precommit functions, global onPrecommit callback, execution semantics,
interaction with existing features, and browser compatibility.
https://claude.ai/code/session_01VQssND6WbN5jHEqYT1kWGj